Skip to content

Blackholio - Logging back in and resuming gameplay#2990

Merged
jdetter merged 5 commits into
masterfrom
jdetter/login-and-resume-gameplay
Aug 8, 2025
Merged

Blackholio - Logging back in and resuming gameplay#2990
jdetter merged 5 commits into
masterfrom
jdetter/login-and-resume-gameplay

Conversation

@jdetter

@jdetter jdetter commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Description of Changes

  • Previous to this PR if you login, create a player, then logout and log back in you are prompted for a username again instead of just resuming your gameplay. This is confusing to players because it seems like your token is not being reused and you are just creating a new player.

API and ABI breaking changes

None

Expected complexity level and risk

1 - this is a demo change but technically affects the testsuite

Testing

  1. Clear your token, then open the game, create a player. Then logout
  2. Without clearing your token, log back into the game.
  3. Make sure that:
  • Your username is correct
  • Your circles are where you left them (and the amount of circles is correct.)

@jdetter jdetter requested a review from rekhoff July 28, 2025 07:16
@jdetter

jdetter commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

Copied from here: clockworklabs/Blackholio#33

@jdetter jdetter force-pushed the jdetter/login-and-resume-gameplay branch from fdff40a to c4675cd Compare July 28, 2025 08:41
rekhoff
rekhoff approved these changes Jul 28, 2025
View reviewed changes

@rekhoff rekhoff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed and approved prior to move from clockworklabs/Blackholio#33
Flagging this as approved here.

@bfops bfops changed the title Logging back in and resuming gameplay Blackholio - Logging back in and resuming gameplay Jul 28, 2025
@bfops bfops added the release-any Can land in any release window. Will not block a release deployment. label Jul 28, 2025
@jdetter

jdetter commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

benchmarks please

@github-actions

github-actions Bot commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
Criterion benchmark results

Error when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.

Caused by:
Couldn't find AWS credentials in environment, credentials file, or IAM role.

@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Callgrind benchmark in progress...

@jdetter jdetter enabled auto-merge August 8, 2025 14:53
@jdetter jdetter added this pull request to the merge queue Aug 8, 2025
Merged via the queue into master with commit 18b29c7 Aug 8, 2025
25 checks passed
@jdetter jdetter mentioned this pull request Aug 8, 2025
Merged
@bfops bfops deleted the jdetter/login-and-resume-gameplay branch May 6, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rekhoff rekhoff rekhoff approved these changes

Assignees

No one assigned

Labels

release-any Can land in any release window. Will not block a release deployment.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdetter @rekhoff @bfops